Merge pull request #24 from SolarRepublic/updates-post-migration

Updates post migration
scrtlabs · Dec 19, 2024 · fae2f66 · fae2f66
2 parents e78ee51 + 5cf46e9
commit fae2f66
Show file tree

Hide file tree

Showing 18 changed files with 3,772 additions and 3,121 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -37,19 +37,22 @@ gas_evaporation = []
 cosmwasm-std = { package = "secret-cosmwasm-std", version = "1.1.11"  }
 cosmwasm-storage = { package = "secret-cosmwasm-storage", version = "1.1.11"  }
 rand = { version = "0.8.5", default-features = false }
-# secret-toolkit = { version = "0.10.0", default-features = false, features = ["permit", "storage", "viewing-key"] }
-secret-toolkit = { git = "https://github.com/SolarRepublic/secret-toolkit.git", default-features = false, features = ["permit", "storage", "viewing-key", "notification"], rev = "8aed92d589dc119f69d20f8538d5a6eea8003d95" }
-# secret-toolkit-crypto = { version = "0.10.0", default-features = false, features = ["hash"] }
-secret-toolkit-crypto = { git = "https://github.com/SolarRepublic/secret-toolkit.git", default-features = false, features = ["hash"], rev = "8aed92d589dc119f69d20f8538d5a6eea8003d95" }
+# secret-toolkit = { version = "0.10.2", default-features = false, features = ["permit", "storage", "viewing-key", "notification"] }
+secret-toolkit = { git = "https://github.com/SolarRepublic/secret-toolkit.git", default-features = false, features = ["permit", "storage", "viewing-key", "notification"], rev = "4a3d119d24bcf00cc30baf3f20a5b8f6bed65ca4" }
+# secret-toolkit-crypto = { version = "0.10.2", default-features = false, features = ["hash", "hkdf", "rand"] }
+secret-toolkit-crypto = { git = "https://github.com/SolarRepublic/secret-toolkit.git", default-features = false, features = ["hash", "hkdf", "rand"], rev = "4a3d119d24bcf00cc30baf3f20a5b8f6bed65ca4" }
 static_assertions = "1.1.0"
 
+rand_core = { version = "0.6.4", default-features = false }
+rand_chacha = { version = "0.3.1", default-features = false }
 schemars = "0.8.12"
 serde = { version = "1.0.158", default-features = false, features = ["derive"] }
 serde-big-array = "0.5.1"
 base64 = "0.21.0"
 constant_time_eq = "0.3.0"
-primitive-types = { version = "0.12.2", default-features = false }
-minicbor-ser = "0.2.0"
+primitive-types = { version = "0.13.1", default-features = false }
+minicbor = "0.25.1"
+hex = "0.4.3"
 
 [dev-dependencies]
 cosmwasm-schema = { version = "1.1.8" }
diff --git a/README.md b/README.md
@@ -1,6 +1,6 @@
 # SNIP-20 Reference Implementation
 
-This is an implementation of a [SNIP-20](https://github.com/SecretFoundation/SNIPs/blob/master/SNIP-20.md), [SNIP-21](https://github.com/SecretFoundation/SNIPs/blob/master/SNIP-21.md), [SNIP-22](https://github.com/SecretFoundation/SNIPs/blob/master/SNIP-22.md), [SNIP-23](https://github.com/SecretFoundation/SNIPs/blob/master/SNIP-23.md), [SNIP-24](https://github.com/SecretFoundation/SNIPs/blob/master/SNIP-24.md), [SNIP-25](https://github.com/SecretFoundation/SNIPs/blob/master/SNIP-25.md) and [SNIP-26](https://github.com/SecretFoundation/SNIPs/blob/master/SNIP-26.md) compliant token contract.
+This is an implementation of a [SNIP-20](https://github.com/SecretFoundation/SNIPs/blob/master/SNIP-20.md), [SNIP-21](https://github.com/SecretFoundation/SNIPs/blob/master/SNIP-21.md), [SNIP-22](https://github.com/SecretFoundation/SNIPs/blob/master/SNIP-22.md), [SNIP-23](https://github.com/SecretFoundation/SNIPs/blob/master/SNIP-23.md), [SNIP-24](https://github.com/SecretFoundation/SNIPs/blob/master/SNIP-24.md), [~~SNIP-25~~](https://github.com/SecretFoundation/SNIPs/blob/master/SNIP-25.md), [SNIP-26](https://github.com/SecretFoundation/SNIPs/blob/master/SNIP-26.md), [~~SNIP-50~~](https://github.com/SecretFoundation/SNIPs/blob/master/SNIP-50.md) and [SNIP-52](https://github.com/SecretFoundation/SNIPs/blob/master/SNIP-52.md) compliant token contract.
 
 > **Note:**
 > The master branch contains new features not covered by officially-released SNIPs and may be subject to change. When releasing a token on mainnet, we recommend you start with a [tagged release](https://github.com/scrtlabs/snip20-reference-impl/tags) to ensure compatibility with SNIP standards.
@@ -66,112 +66,27 @@ All transactions are encrypted, so if you want to see the error returned by a fa
 
 `secretcli q compute tx <TX_HASH>`
 
-# SNIP 25 Security Update
-
-## Security Changes
-1. Implemented the ability to have decoy addresses for every operation that access account's balance
-2. Converted every add operation related to account's balance and total supply
-3. Started using u128 instead of Uint128
-
-## Decoys
-### Transaction That Support Decoys
-1. Redeem
-2. Deposit
-3. Transfer
-4. TransferFrom
-5. Send
-6. SendFrom
-7. Burn
-8. BurnFrom
-9. Mint
-10. BatchTransfer - For every action (The strength of the decoys will be the minimal strength of all of the actions)
-11. BatchSend - For every action (The strength of the decoys will be the minimal strength of all of the actions)
-12. BatchTransferFrom - For every action (The strength of the decoys will be the minimal strength of all of the actions)
-13. BatchSendFrom - For every action (The strength of the decoys will be the minimal strength of all of the actions)
-14. BatchMint - For every action (The strength of the decoys will be the minimal strength of all of the actions)
-15. BatchBurnFrom - For every action (The strength of the decoys will be the minimal strength of all of the actions)
-
-### Example
-```secretcli tx compute execute <contract-address> '{"transfer":{"recipient":"<address>","amount":"<amount>", "entropy":"<base64_encoded_entropy>", "decoys":<[addresses_list]>}}' --from <account>```
-
-## Future Work
-| Topic | Immediate-term solution | Medium-term solution | Long-term solution |
-| --- | --- | --- | --- |
-| Receiver privacy | Decoys - offer limited privacy, since it depends a lot on how you choose decoys. There’s probably no way to select decoys effectively enough, and thus it only makes it a bit harder but effectively doesn’t provide receiver privacy to a sophisticated long-term attacker | Some sort of bucketing? - still no clear path forward| ORAM? - still no clear path forward |
-| Transfer amount privacy - subtractions (Transfer/Send/Burn) | None | None | Merkle proofs for storage reads - will make it very difficult to simulate transactions and play with storage. |
-
-# SNIP 25 Other Updates
-
-## All Allowances
-Adds the ability for an owner to query for all allowances they have given out, as well as for a spender to query for all allowances they have received.
-
-## Queries
-
-### AllowancesGiven
-
-This query MUST be authenticated.
-
-Returns the list of allowances given out by the current account as an owner, as well as the total count of allowances given out.
-
-Results SHOULD be paginated. Results MUST be sorted in reverse chronological order by the datetime at which the allowance was first created (i.e., order is not determined by expiration, nor by last modified).
-
-#### Request
-
-| Name | Type | Description | optional |
-| ---- | ---- | ----------- | -------- |
-| [with_permit].query.allowances_given.owner | string | Account from which tokens are allowed to be taken | no |
-| [with_permit].query.allowances_given.page_size | number | Number of allowances to return, starting from the latest. i.e. n=1 will return only the latest allowance | no |
-| [with_permit].query.allowances_given.page | number | Defaults to 0. Specifying a positive number will skip page * page_size txs from the start. | yes |
-
-#### Response
-```json
-{
-  "allowances_given": {
-    "owner": "<address>",
-    "allowances": [
-      {
-        "spender": "<address>",
-        "allowance": "Uint128",
-        "expiration": 1234,
-      },
-      { "...": "..." }
-    ],
-    "count": 200
-  }
-}
-```
-
-### AllowancesReceived
-
-This query MUST be authenticated.
-
-Returns the list of allowances given to the current account as a spender, as well as the total count of allowances received.
-
-Results SHOULD be paginated. Results MUST be sorted in reverse chronological order by the datetime at which the allowance was first created (i.e., order is not determined by expiration).
-
-#### Request
-
-| Name | Type | Description | optional |
-| ---- | ---- | ----------- | -------- |
-| [with_permit.]query.allowances_received.spender | string | Account which is allowed to spend tokens on behalf of the owner | no |
-| [with_permit.]query.allowances_received.page_size	| number | Number of allowances to return, starting from the latest. i.e. n=1 will return only the latest allowance | no |
-| [with_permit.]query.allowances_received.page | number | Defaults to 0. Specifying a positive number will skip page * page_size txs from the start. | yes |
-
-#### Response
-
-```json
-{
-  "allowances_received": {
-    "spender": "<address>",
-    "allowances": [
-      {
-        "owner": "<address>",
-        "allowance": "Uint128",
-        "expiration": 1234,
-      },
-      { "...": "..." }
-    ],
-    "count": 200
-  }
-}
-```
+## Privacy Enhancements
+
+ - All transfers/sends (including batch and *_from) use the delayed write buffer (dwb) to address "spicy printf" storage access pattern attacks.
+ - Additionally, a bitwise trie of bucketed entries (dwb) creates dynamic anonymity sets for senders/owners, whose balance must be checked when transferring/sending. It also enhances privacy for recipients.
+ - When querying for Transaction History, each event's `id` field returned in responses are deterministically obfuscated by `ChaChaRng(XorBytes(ChaChaRng(actual_event_id), internal_secret)) >> (64 - 53)` for better privacy. Without this, an attacker could deduce the number of events that took place between two transactions.
+
+## SNIP-52: Private Push Notifications
+
+This contract publishes encrypted messages to the event log which carry data intended to notify recipients of actions that affect them, such as token transfer and allowances.
+
+Direct channels:
+ - `recvd` -- emitted to a recipient when their account receives funds via one of `transfer`, `send`, `transfer_from`, or `send_from`. The notification data includes the amount, the sender, and the memo length.
+ - `spent` -- emitted to an owner when their funds are spent, via one of `transfer`, `send`, `transfer_from` or `send_from`. The notification data includes the amount, the recipient, the owner's new balance, and a few other pieces of information such as memo length, number of actions, and whether the spender was the transaction's sender.
+ - `allowance` -- emitted to a spender when some allower account has granted them or modified an existing allowance to spend their tokens, via `increase_allowance` or `decrease_allowance`. The notification data includes the amount, the allower, and the expiration of the allowance.
+
+Group channels:
+ - `multirecvd` -- emitted to a group of recipients (up to 16) when a `batch_transfer`, `batch_send`, `batch_transfer_from`, or `batch_send_from` has been executed. Each recipient will receive a packet of data containing the amount they received, the last 8 bytes of the owner's address, and some additional metadata.
+ - `multispent` -- emitted to a group of spenders (up to 16) when a `batch_transfer_from`, or `batch_send_from` has been executed. Each spender will receive a packet of data containing the amount that was spent, the last 8 bytes of the recipient's address, and some additional metadata.
+
+
+## Security Features
+
+ - Transfers to the contract itself will be rejected to prevent accidental loss of funds.
+ - The migration allows for a one-time processing of refunding any previous transfers made to the contract itself.