Fix bug: high word of size for compressed files on windows was ignored #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @scullionw. I hope you would find time to review/merge My PR. Because currently functionality of compressed files is broken on Windows. |
|
Hi! sorry for the delay! I had indeed misunderstood the docs. Thanks for the PR, it looks good to me! |
|
Thanks. Perhaps I would be able to work on #5 next week. |
|
it's sad that on Linux in btrfs you need CAP_SYSADMIN (which practically means being root) to be able to get compressed file size :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a null pointer passing in all the time. This signaled to function that we "don't want" high word.
In C (or in win API at least) it's a common pattern to accept pointers for optional arguments.
Notice, if you would work with such APIs in future.
In case when we need to check pointers for zero, like was in the original code: then the function would accept double pointer (
void**). Then we have a local variable defined as a regular pointer and an argument defined as a double-pointer. Then library could write something into our pointer.P.S. I'm not sure if I should bump version instead of a maintainer, but made it just in case.