Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with IPython 9 #3499

Merged
merged 3 commits into from
Mar 11, 2025
Merged

Fix compatibility with IPython 9 #3499

merged 3 commits into from
Mar 11, 2025

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Mar 11, 2025

IPython removed the IPython.display.set_matplotlib_formats API we call in the settings

@flying-sheep flying-sheep added this to the 1.11.1 milestone Mar 11, 2025
@flying-sheep flying-sheep marked this pull request as ready for review March 11, 2025 11:29
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.52%. Comparing base (672675d) to head (1e6614a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/scanpy/_settings.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3499   +/-   ##
=======================================
  Coverage   75.52%   75.52%           
=======================================
  Files         113      113           
  Lines       13229    13229           
=======================================
  Hits         9991     9991           
  Misses       3238     3238           
Files with missing lines Coverage Δ
src/scanpy/_settings.py 88.75% <0.00%> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@flying-sheep flying-sheep merged commit 1c3c1e1 into main Mar 11, 2025
11 of 14 checks passed
@flying-sheep flying-sheep deleted the pa/fix-ipython-9 branch March 11, 2025 12:47
meeseeksmachine pushed a commit to meeseeksmachine/scanpy that referenced this pull request Mar 11, 2025
flying-sheep added a commit that referenced this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated use of IPython.display.set_matplotlib_formats
2 participants