Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning when running bounding box query if points is present #777

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

BioinfoTongLI
Copy link

No description provided.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (a89d16d) to head (3afffc6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #777      +/-   ##
==========================================
- Coverage   91.85%   91.84%   -0.01%     
==========================================
  Files          45       45              
  Lines        6885     6895      +10     
==========================================
+ Hits         6324     6333       +9     
- Misses        561      562       +1     
Files with missing lines Coverage Δ
src/spatialdata/_core/query/spatial_query.py 95.49% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

@@ -514,6 +514,11 @@ def _(
min_coordinate = _parse_list_into_array(min_coordinate)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add remark on performance with points to function documentation in Notes header

@BioinfoTongLI BioinfoTongLI changed the title add options to filter different elements with bounding box query function add warning when running bounding box query if points is present Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants