Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events tab only showing at most one disruption for any event, even when there are multiple ones #470

Open
kbr-scylla opened this issue Oct 2, 2024 · 1 comment · May be fixed by #575
Open
Assignees

Comments

@kbr-scylla
Copy link

For example let's take https://argus.scylladb.com/test/5cd4bfe3-231b-4f48-99bc-f21ebd1b5efe/runs?additionalRuns%5B%5D=e330a762-61b1-4318-a55c-0b072d4df26e

we have some events there, e.g.:
Image
the event shows that there was a disruption: disrupt_remove_node_then_add_node at the time of the event (2024-09-10 16:59:35.814)

but from Nemesis tab we can learn that we had multiple disruptions running during this time:
Image
both disrupt_remove_node_then_add_node and disrupt_create_index started before 2024-09-10 16:59:35.814 and finished after that.

So the event should show both disruptions. I think the implementation assumes there's at most one disruption at any given moment, but SCT has parallel nemeses.

cc @temichus

@k0machi k0machi added the bug Something isn't working label Oct 3, 2024
@fruch
Copy link
Contributor

fruch commented Nov 11, 2024

@kbr-scylla

look inside the event, during_nemesis= actuall show exactly what you are looking

yes the graphical one Argus showing isn't show everything, and should be taking it first from the event information itself (data created by SCT itself), and only then fallback to lookups in the nemesis information.

@fruch fruch removed the bug Something isn't working label Dec 2, 2024
k0machi added a commit to k0machi/argus that referenced this issue Jan 20, 2025
Some events happen during multiple nemeses. This commit updates the
logic to find all nemeses that were active during a specific event,
instead of just looking for one like previously.

Fixes scylladb#470
@k0machi k0machi linked a pull request Jan 20, 2025 that will close this issue
k0machi added a commit to k0machi/argus that referenced this issue Jan 20, 2025
Some events happen during multiple nemeses. This commit updates the
logic to find all nemeses that were active during a specific event,
instead of just looking for one like previously.

Fixes scylladb#470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants