Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(EventsTab): Multi-nemesis events #575

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

k0machi
Copy link
Collaborator

@k0machi k0machi commented Jan 20, 2025

Some events happen during multiple nemeses. This commit updates the
logic to find all nemeses that were active during a specific event,
instead of just looking for one like previously.

Fixes #470

@k0machi k0machi self-assigned this Jan 20, 2025
@k0machi k0machi requested review from fruch and soyacz January 20, 2025 09:38
@k0machi
Copy link
Collaborator Author

k0machi commented Jan 20, 2025

From the very same test as reported in the original issue:

image

Some events happen during multiple nemeses. This commit updates the
logic to find all nemeses that were active during a specific event,
instead of just looking for one like previously.

Fixes scylladb#470
@k0machi k0machi force-pushed the run-events-multiple-nemesis branch from 3e74413 to 156c00d Compare January 20, 2025 09:42
Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@soyacz soyacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one remark (I'm not sure if important). LGTM

frontend/TestRun/StructuredEvent.svelte Show resolved Hide resolved
@k0machi k0machi merged commit cb6722c into scylladb:master Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events tab only showing at most one disruption for any event, even when there are multiple ones
3 participants