Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(summary-widget): summary widget #530

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

soyacz
Copy link
Collaborator

@soyacz soyacz commented Dec 3, 2024

View widged showing tests statuses and results per Scylla version. Each test can be expanded to see results (tables) with key metrics. Initial features:

  1. Results summary by scylla version (date, scm revision)
  2. passed tests are collapsed by default
  3. not run tests marked as warning
  4. hiding tables with all cells green ... many more but small ones.

caveats:

  1. works only with scylla-server package
  2. tests filtering based on release (oss vs enterprise) implementation is poor as will work only with scylla-master and scylla-enterprise argus releases
  3. key metrics are hardcoded, followup issue: https://github.com/scylladb/qa-tasks/issues/1821

Did a refactor of ResultsTab - extracted ResultTable to be able to reuse it across different parts of Argus (like Summary Widget)

refs: #486

View widged showing tests statuses and results per Scylla version.
Each test can be expanded to see results (tables) with key metrics.
Initial features:
1. Results summary by scylla version (date, scm revision)
2. passed tests are collapsed by default
3. not run tests marked as warning
4. hiding tables with all cells green
... many more but small ones.

caveats:
1. works only with scylla-server package
2. tests filtering based on release (oss vs enterprise) implementation
   is poor as will work only with scylla-master and scylla-enterprise
   argus releases
3. key metrics are hardcoded, followup issue:
   scylladb/qa-tasks#1821

Did a refactor of ResultsTab - extracted ResultTable to be able to reuse
it across different parts of Argus (like Summary Widget)

refs: scylladb#486
@soyacz soyacz requested review from fruch and k0machi December 3, 2024 15:49
@soyacz
Copy link
Collaborator Author

soyacz commented Dec 3, 2024

preview on staging - see Performance Regression Tests View

@fruch
Copy link
Contributor

fruch commented Dec 3, 2024

filter buttons, are not collapsing with the job
image

@fruch
Copy link
Contributor

fruch commented Dec 3, 2024

I think the ability to copy the version string (including git sha), now it's displayed only on the dropdown, and it's not easy to copy anything from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants