Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(TestRunInfo.svelte): Add popup hints for copy buttons #537

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

k0machi
Copy link
Collaborator

@k0machi k0machi commented Dec 16, 2024

This commit adds success indicators when user does copy-to-clipboard
actions, making it less confusing.

Fixes #431

@k0machi k0machi self-assigned this Dec 16, 2024
@k0machi k0machi requested review from fruch, soyacz and roydahan December 16, 2024 13:08
Copy link
Collaborator

@soyacz soyacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k0machi k0machi force-pushed the show-tooltip-on-copy branch 2 times, most recently from 01a7dc5 to b4c3578 Compare December 19, 2024 12:57
This commit adds success indicators when user does copy-to-clipboard
actions, making it less confusing.

Fixes scylladb#431
@k0machi k0machi force-pushed the show-tooltip-on-copy branch from b4c3578 to 4ff6b68 Compare January 13, 2025 13:49
@k0machi k0machi requested a review from fruch January 13, 2025 14:28
Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k0machi k0machi merged commit c3cd6b9 into scylladb:master Jan 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing buttons text: "Hydra Show Monitor". The button seems to have no effect
3 participants