Merge upstream changes #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#201) * Fix reflection logic of aws-java-sdk-v2 credential providers DynamoDB connector uses reflection to load custom credential providers. When the package was upgraded to use aws-java-sdk-v2, the package was only updated to fix the differing classpaths. SDK-v2 credential providers no longer use constructors but static create() methods to initialize the instance which was not handled in the previous implementation. This PR accounts for this use case and includes a fallback to the original logic to ensure backwards compatibility. * Refactor and fix javadoc --------- Co-authored-by: Sugath Madurawe <[email protected]>
* Set default credential provider to sdk's default provider The default credential provide dynamo-db connector falls back to is InstanceProfileCredentialProvider. However, instance profile is not available in all deployment environments (e.g. EMR Serverless). Instead, aws-java-sdk-v2 default provider should be used as the fallback. * Add unit test * nit: fix imports --------- Co-authored-by: Sugath Madurawe <[email protected]>
julienrf
force-pushed
the
merge-upstream
branch
from
697f48b to
0553a79
Compare
julienrf
force-pushed
the
merge-upstream
branch
from
0553a79 to
6d41de7
Compare
julienrf
added a commit
to julienrf/scylla-migrator
that referenced
this pull request
Aug 30, 2024
It is not needed now that `emr-dynamodb-connector` defaults to the same credentials provider (see awslabs/emr-dynamodb-connector#203 and scylladb/emr-dynamodb-connector#9).
julienrf
added a commit
to julienrf/scylla-migrator
that referenced
this pull request
Aug 31, 2024
It is not needed now that `emr-dynamodb-connector` defaults to the same credentials provider (see awslabs/emr-dynamodb-connector#203 and scylladb/emr-dynamodb-connector#9).
julienrf
added a commit
to julienrf/scylla-migrator
that referenced
this pull request
Sep 2, 2024
It is not needed now that `emr-dynamodb-connector` defaults to the same credentials provider (see awslabs/emr-dynamodb-connector#203 and scylladb/emr-dynamodb-connector#9).
tarzanek
pushed a commit
to scylladb/scylla-migrator
that referenced
this pull request
Sep 2, 2024
It is not needed now that `emr-dynamodb-connector` defaults to the same credentials provider (see awslabs/emr-dynamodb-connector#203 and scylladb/emr-dynamodb-connector#9).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefaultCredentialsProvider, which should help with DynamoDB migration is unable to read credentials. scylla-migrator#122