-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(root): introduce schema-seed #376
feat(root): introduce schema-seed #376
Conversation
74d1bb3
to
b7d3e79
Compare
b7d3e79
to
d9160c1
Compare
I don't immediately see why splitting is a must. Could you elaborate? |
Say you want to change payload, but keep the schema, in current implementation you have to provide a schema file. As of now we use |
If there is an option to provide schema file then I guess it will be different than one generated by seed, so no need to be compatible here. I think the problem is subtle, and solving it needs to take concurrency into consideration |
Not exactly, when gemini starts it outputs schema it generated, you can take it as it is or updated and feed back to gemini, it allows you to have either exact same schema or something different.
Agree, it is not major issue. |
You can but why would you do it? If you want to achieve the same behaviour you need to provide the same seed. In such case you don't need to provide any file because generated schema will be the same anyway. |
Ahh, 100% agree, but there is one problem - if we change way schema is generated, change order of invoking |
Such changes are breaking and need to be announced (once generation is stable, now it doesn't matter much). And you won't achieve the same result if you've changed something the requests likely also will be different. Moreover this can be alleviated by pinning version of gemini to test run, and it would be a solution covering more cases. |
True, but it does not relate to schema, queries is another topic.
Agree. |
d9160c1
to
46ef027
Compare
9d5b1b7
to
674400b
Compare
@nuivall, are you ok with merging it ? |
674400b
to
6d737e4
Compare
6d737e4
to
ab185de
Compare
Statement data and schema seed are the same at the moment.
We need to split them in order to be able to run different data flow on the same schema