Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(docker): Docker image and goreleaser #423

Merged
merged 1 commit into from
Sep 9, 2024
Merged

feature(docker): Docker image and goreleaser #423

merged 1 commit into from
Sep 9, 2024

Conversation

CodeLieutenant
Copy link
Contributor

This PR improves the building and releasing Gemini. Adds new multi-stage Docker build and upgrades goreleaser to the latest yaml spec.

Since there is no problem in the codebase (no warnings and errors) there is no reason not to upgrade to GO 1.23.

@CodeLieutenant CodeLieutenant self-assigned this Sep 3, 2024
@CodeLieutenant CodeLieutenant added the enhancement New feature or request label Sep 3, 2024
@CodeLieutenant CodeLieutenant marked this pull request as ready for review September 3, 2024 09:34
.github/workflows/go.yml Outdated Show resolved Hide resolved
.github/workflows/go.yml Outdated Show resolved Hide resolved
.github/workflows/go.yml Outdated Show resolved Hide resolved
.goreleaser.yml Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
.github/workflows/go.yml Show resolved Hide resolved
.goreleaser.yml Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@dkropachev
Copy link
Collaborator

@vponomaryov , does it looks good for you ?

Copy link
Collaborator

@vponomaryov vponomaryov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkropachev
Copy link
Collaborator

@CodeLieutenant , thanks for nice PR, can we merge it ?

@CodeLieutenant
Copy link
Contributor Author

@CodeLieutenant , thanks for nice PR, can we merge it ?

Yes it's ready

@dkropachev dkropachev merged commit 7600ee9 into scylladb:master Sep 9, 2024
1 check passed
@CodeLieutenant CodeLieutenant deleted the feat/docker-release branch September 9, 2024 17:03
@fruch
Copy link
Collaborator

fruch commented Sep 9, 2024

@CodeLieutenant next release would be after we introduce the flag to disable mv ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants