feature(ci): release gemini using goreleaser and github actions #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeLieutenant
added
enhancement
CodeLieutenant
force-pushed
the
feat/gh-actions-release
branch
from
d5d19f5 to
09c4bc8
Compare
dkropachev
requested changes
Sep 16, 2024
CodeLieutenant
force-pushed
the
feat/gh-actions-release
branch
from
09c4bc8 to
ff79840
Compare
Signed-off-by: Dusan Malusev <[email protected]>
CodeLieutenant
force-pushed
the
feat/gh-actions-release
branch
from
ff79840 to
1800cc8
Compare
dkropachev
requested changes
Sep 17, 2024
| name: goreleaser | ||
|
|
||
| on: | ||
| push: |
There was a problem hiding this comment.
When do you want it to be triggered ? Currently it is going to be run on every push for every branch.
We can trigger it when:
- Maintainer calls it via actions tab
on:
workflow_dispatch
- Make it triggered automagically if PR have label is being merged:
on:
pull_request:
branches:
- main
types: [closed]
jobs:
my-action:
if: ${{ github.event.pull_request.merged }}
There was a problem hiding this comment.
that's not correct, read the next line, it's limited to tag pushes only
There was a problem hiding this comment.
we might want to limit this to the master branch.
but this workflow, won't be running on PRs
dkropachev
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make use of goreleaser, we need GitHub Action to build and
geminiand generate changelogThis is the action to do so.
Commented out
blobInside the repository, we don't have any AWS Keys to upload gemini binaries to S3 Bucket. until that gets sorted out, it is better to leave it commented and have the gemini release as soon as possible to test the #424 in SCT.