HostSelectionPolicy: add Reset method, Session.Close: call HostSelect… #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
approved these changes
Jun 20, 2024
|
@moguchev pls rebase on master |
|
Okay |
|
@moguchev ping |
moguchev
force-pushed
the
host_policy_reset
branch
from
435fcd1 to
b22eaf2
Compare
|
done |
sylwiaszunejko
approved these changes
Jun 28, 2024
|
@moguchev thank you for your contributions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure this is even the right idea but in some cases panic in our application (shared policy) caused us inconvenience. In my opinion if one session is closed, another session can start working with host policy (because the condition is fulfilled that there is only one session working with token aware host policy).
I propose to consider this request)