Fix timestamp serialization into time.Time, makes zero data <-> zeroTimestamp
#375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
requested changes
Dec 12, 2024
| if p == nil { | ||
| *v = time.Time{} | ||
| } else { | ||
| *v = zeroTimestamp.UTC() |
There was a problem hiding this comment.
it should be in UTC already
illia-li
force-pushed
the
il/fix/marshal/timestamp_zero_nil_time
branch
from
9b9fb7b to
bf0f663
Compare
Changes:
1) Unmarshalling `zero data` into `time.Time` return `time.Time{}` before, now returns `zeroTimestamp`
2) Marshalling the `0001-1-1T00:00:00Z` value of the `time.Time` return `zero data` before, now returns a data that is equivalent to the difference between `0001-1-1T00:00:00Z` and `1970-1-1T00:00:00Z`
3) Tests fixed
illia-li
changed the title
timestamp fixed zero data serialization for time.Timetimestamp serialization into time.Time, makes zero data <-> zeroTimestamp
illia-li
force-pushed
the
il/fix/marshal/timestamp_zero_nil_time
branch
from
bf0f663 to
5f6e337
Compare
illia-li
changed the title
timestamp serialization into time.Time, makes zero data <-> zeroTimestamptimestamp serialization into time.Time, makes zero data <-> zeroTimestamp
dkropachev
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
zero dataintotime.Timereturntime.Time{}before, now returnszeroTimestamp0001-1-1T00:00:00Zvalue of thetime.Timereturnzero databefore, now returns a data that is equivalent to the difference between0001-1-1T00:00:00Zand1970-1-1T00:00:00Ztime.Timeon marshalling and relevant tests.