Skip to content

Commit

Permalink
Tracing: added OpenTelemetry integration test
Browse files Browse the repository at this point in the history
The test verifies that span tree structure and status code are valid.
Speculative executions are run parallel to the main thread, so some
of them can finish only after query result has been returned.
Thus, in order to collect span data from entire request, we decided
to wait until all speculative executions end. The main thread uses
conditional variable `allEnded` to wait for them and lock is used
for concurrent mutation of activeSpans.
  • Loading branch information
wprzytula committed Aug 4, 2022
1 parent 2c216cd commit 15e2d53
Show file tree
Hide file tree
Showing 2 changed files with 872 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ public void setHasMorePages(boolean hasMorePages) {
@Override
public void setRowsCount(int rowsCount) {
assertStarted();
span.setAttribute("db.scylla.rows_count", rowsCount);
span.setAttribute("db.scylla.rows_count", Integer.toString(rowsCount));
}

@Override
Expand Down
Loading

0 comments on commit 15e2d53

Please sign in to comment.