Add TestRule for preserving logs #191
Conversation
Bouncheck
force-pushed
the
scylla-4.x-testrule
branch
from
f59a52b to
2a93e64
Compare
This TestRule can be combined with other CCM Rules to prevent them from deleting logs of failed tests during cleanup.
Bouncheck
force-pushed
the
scylla-4.x-testrule
branch
from
2a93e64 to
fdd62ea
Compare
|
|
||
| public CcmBridge getCcmBridge() { | ||
| return ccmBridge; | ||
| } |
There was a problem hiding this comment.
Why is this method moved here from CustomCcmRule?
There was a problem hiding this comment.
Could be an accident, but this was so long ago that I need to look at it again.
There was a problem hiding this comment.
I think it was to allow combining new rule with all other rules. New rule needs ccmBridge to modify its state.
| import org.junit.rules.TestWatcher; | ||
| import org.junit.runner.Description; | ||
|
|
||
| public class PreserveLogsRule extends TestWatcher { |
There was a problem hiding this comment.
Question - why not to make it configurable from environment variable ? So that it could be easily set for whole run.
There was a problem hiding this comment.
IIRC this was the simplest way to have the rule react only in case of failure. The goal was to skip logs of passing runs.
Global switch would be nice for running locally, but I'm not sure if we want CI to keep regularly uploading unnecessary log files.
There was a problem hiding this comment.
We definitely would want to store ccm logs on test failures on cicd.
There was a problem hiding this comment.
Let's make it global flag that controls whether we keep ccm logs after the test or not.
This TestRule can be combined with other CCM Rules to prevent them from deleting logs of failed tests during cleanup.