[4.x] mapper-processor: record annotation warning fix #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping - can this be reviewed? |
avelanarius
force-pushed
the
record-warning-fix
branch
from
f699942 to
8af74b5
Compare
avelanarius
force-pushed
the
record-warning-fix
branch
from
8b90b6f to
8af74b5
Compare
|
Bouncheck
approved these changes
Jan 7, 2024
Java 14 introduces record keyword which stands for immutable data class. Records require only the name and types of fields. Java generates some code to operate on the record's objects - including public getter methods. When annotating record with @entity annotation and its field with one of the exclusive annotations, we get a compilation warning: @entity public record FooRecord( @PartitionKey int fooPK, @ClusteringColumn String fooCC ) { } /home/mikolajuzarski/playground/java-driver-test/src/main/java/org/example/FooRecord.java:9:27 java: [FooRecord.fooPK] @PartitionKey should be used either on the field or the getter, but not both. The annotation on this field will be ignored. /home/mikolajuzarski/playground/java-driver-test/src/main/java/org/example/FooRecord.java:10:34 java: [FooRecord.fooCC] @ClusteringColumn should be used either on the field or the getter, but not both. The annotation on this field will be ignored. Java duplicates the annotation on the record's field to the corresponding getter method as well. This results in generating the warning when using records and exclusive field annotations. This commit fixes the issue, so the compilation warning message is not printed for records. Fixes scylladb#246
avelanarius
force-pushed
the
record-warning-fix
branch
from
8af74b5 to
b0c7d38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #246