-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.x: Adjust for zero token nodes #399
base: scylla-3.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bouncheck , thanks, looks good, could you please add another test for Zero-token Datacenter
from #317
@Bouncheck , please consider fixing code not to log following error:
|
58d2072
to
a557147
Compare
a557147
to
1b13045
Compare
Added some tests. The current version slightly differs from what's proposed in #317 , for example driver won't fail when executing queries after connecting to zero-token DC. It just won't direct queries to it. |
In one of the tests i create a table in a new keyspace with general replication_factor in multi-dc setting and I do not see this error now. |
Some of the tests fail, because their hosts have |
Adds ZeroTokenNodesIT that checks the behaviour of the driver when zero-token nodes are involved. Changes behavior of the driver in regards to zero-token nodes. Those nodes will be ignored if encountered in `system.peers` table. If provided as a contact point, the driver will attempt to connect to it, but will not populate metadata with it. This results in zero-token nodes being not included in query planning. Note that the `isValidPeer` method had the check for nullity of `tokens` column moved from extended peer check to the regular check.
1b13045
to
c96f87b
Compare
Adds ZeroTokenNodesIT that checks the behaviour of the driver when zero-token
nodes are involved.
Changes behavior of the driver in regards to zero-token nodes. Those nodes
will be ignored if encountered in
system.peers
table. If provided as acontact point, the driver will attempt to connect to it, but will not populate
metadata with it. This results in zero-token nodes being not included in
query planning.
Note that the
isValidPeer
method had the check for nullity oftokens
columnmoved from extended peer check to the regular check.