Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate tablets when table or keyspace is deleted #399

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

dkropachev
Copy link
Collaborator

Delete tablets for table or keyspace when one is deleted.
When host is removed from cluster delete all tablets that have this host in it.
Ensure that if it happens when control connection is reconnection.

Fixes #388

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@dkropachev dkropachev force-pushed the dk/invalidate-tablets branch 2 times, most recently from 11d8d43 to dcd8db3 Compare January 4, 2025 04:03
Unittest interfere into pytest ordering,
which will be needed in next commit
@dkropachev dkropachev force-pushed the dk/invalidate-tablets branch from dcd8db3 to 6faef19 Compare January 4, 2025 12:36
cassandra/metadata.py Outdated Show resolved Hide resolved
cassandra/metadata.py Outdated Show resolved Hide resolved
cassandra/metadata.py Outdated Show resolved Hide resolved
cassandra/tablets.py Outdated Show resolved Hide resolved
cassandra/tablets.py Outdated Show resolved Hide resolved
cassandra/tablets.py Outdated Show resolved Hide resolved
cassandra/tablets.py Outdated Show resolved Hide resolved
cassandra/cluster.py Outdated Show resolved Hide resolved
tests/integration/experiments/test_tablets.py Outdated Show resolved Hide resolved
tests/integration/experiments/test_tablets.py Outdated Show resolved Hide resolved
@dkropachev dkropachev force-pushed the dk/invalidate-tablets branch 2 times, most recently from 4a3a8ad to 65362a6 Compare January 4, 2025 14:59
@dkropachev dkropachev requested a review from Lorak-mmk January 4, 2025 14:59
Copy link

@Lorak-mmk Lorak-mmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 minor comments, and there is one open comment from previous review (about the additional refresh). Apart from that looks good.

cassandra/tablets.py Outdated Show resolved Hide resolved
cassandra/metadata.py Outdated Show resolved Hide resolved
Delete tablets for table or keyspace when one is deleted.
When host is removed from cluster delete all tablets that have this host in it.
Ensure that if it happens when control connection is reconnection.
@dkropachev dkropachev force-pushed the dk/invalidate-tablets branch from 65362a6 to be0bcf2 Compare January 4, 2025 23:01
@dkropachev dkropachev requested a review from Lorak-mmk January 4, 2025 23:52
@dkropachev dkropachev merged commit fdfc7df into master Jan 5, 2025
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make driver invalidate tablets
2 participants