forked from datastax/python-driver
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalidate tablets when table or keyspace is deleted #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
force-pushed
the
dk/invalidate-tablets
branch
2 times, most recently
from
January 4, 2025 04:03
11d8d43
to
dcd8db3
Compare
Unittest interfere into pytest ordering, which will be needed in next commit
dkropachev
force-pushed
the
dk/invalidate-tablets
branch
from
January 4, 2025 12:36
dcd8db3
to
6faef19
Compare
Lorak-mmk
requested changes
Jan 4, 2025
dkropachev
force-pushed
the
dk/invalidate-tablets
branch
2 times, most recently
from
January 4, 2025 14:59
4a3a8ad
to
65362a6
Compare
Lorak-mmk
requested changes
Jan 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left 2 minor comments, and there is one open comment from previous review (about the additional refresh). Apart from that looks good.
Delete tablets for table or keyspace when one is deleted. When host is removed from cluster delete all tablets that have this host in it. Ensure that if it happens when control connection is reconnection.
dkropachev
force-pushed
the
dk/invalidate-tablets
branch
from
January 4, 2025 23:01
65362a6
to
be0bcf2
Compare
Lorak-mmk
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete tablets for table or keyspace when one is deleted.
When host is removed from cluster delete all tablets that have this host in it.
Ensure that if it happens when control connection is reconnection.
Fixes #388
Pre-review checklist
./docs/source/
.Fixes:
annotations to PR description.