Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove is <int> #403

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Remove is <int> #403

merged 1 commit into from
Jan 5, 2025

Conversation

dkropachev
Copy link
Collaborator

It does not match orthodox python style.
And trigger warnings:

  cqlengine/query/test_queryoperators.py:157: SyntaxWarning: "is" with 'int' literal. Did you mean "=="?
    self.assertTrue(len(first_page) is 1)

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

It does not match orthodox python style.
And trigger warnings:
  cqlengine/query/test_queryoperators.py:157: SyntaxWarning: "is" with 'int' literal. Did you mean "=="?
    self.assertTrue(len(first_page) is 1)
@dkropachev dkropachev merged commit 17c7ce0 into master Jan 5, 2025
30 of 32 checks passed
@dkropachev dkropachev deleted the dk/remove-is-int branch January 6, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants