Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix removing key/value in map_column__remove query #413

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

artemki2077
Copy link

@artemki2077 artemki2077 commented Jan 23, 2025

when requesting map_column__remove, in the ModalQuerySet object, in the update function, when requesting a delete operation, the set object is converted to a dict with all values None, which causes an error when calling the to_database function

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@dkropachev
Copy link
Collaborator

@artemki2077 , thanks for your contribution, can I task you with providing a test for this bug.

@dkropachev dkropachev self-assigned this Jan 24, 2025
@artemki2077
Copy link
Author

@artemki2077 , thanks for your contribution, can I task you with providing a test for this bug.

I'm not a specialist in unit tests, but I can try to do it. But there is a bug there if you make any request to map_column__remove. I just copied this query from the documentation, at first I thought I had a mistake somewhere, but then I realized that the error was when calling to_database with the value None, when I added a check to it, everything worked.

@dkropachev
Copy link
Collaborator

@artemki2077 , there are set of tests on the functionality and they work just fine, please check it, probably this problem not in the driver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants