Skip to content

Commit

Permalink
scylla-node/Debian_install.yml: Don't check if the installed scylla v…
Browse files Browse the repository at this point in the history
…ersion appears in the repo exactly once unless we are upgrading

We have a check that validates that a value in `scylla_version` matches exactly one (full) scylla verison
from the repository so that the Role can install it.

However this check is only relevant when we are going to install anything, and when scylla is already
installed and we are not upgrading - we are not going to. Hence, this check is only making noise in such a case.

One common example of such a situation is when a custom build is installed.

Signed-off-by: Vlad Zolotarov <[email protected]>
  • Loading branch information
vladzcloudius committed May 11, 2024
1 parent ec09003 commit ce50d11
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ansible-scylla-node/tasks/Debian_install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
- name: "Validate scylla version correctness"
ansible.builtin.fail:
msg: "Too many/few choices for a requested version '{{ scylla_version_to_install }}': {{ aptversions.stdout_lines }}. Bailing out!"
when: aptversions.stdout_lines | length != 1
when: (not scylla_is_installed or upgrade_version) and aptversions.stdout_lines | length != 1

- name: If Scylla is installed check if it's the same version as requested
fail:
Expand Down

0 comments on commit ce50d11

Please sign in to comment.