Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible-scylla-node: Improves "legacy" support for 'node-exporter' #253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ebenzecri
Copy link
Contributor

This patch improves how 'node_exporter_install' is called and how 'node-exporter' service is started.

Fixes: #249

@ebenzecri ebenzecri force-pushed the issue_249 branch 5 times, most recently from 4543d96 to c4c2fb0 Compare June 21, 2023 19:06
This patch improves how 'node_exporter_install' is called and how 'node-exporter' service is started.

Fixes: scylladb#249

Signed-off-by: Eduardo Benzecri <[email protected]>
@ebenzecri
Copy link
Contributor Author

Installing Scylla Enterprise 2021 from scratch

  • node_exporter_install is executed
  • node-exporter.service is enabled and started
  • scylla-node-exporter.service is not present
  • Molecule tests passed

Installing Scylla Enterprise 2022 from scratch

  • node_exporter_install is not executed
  • node-expoter.service is not present
  • scylla-node-exporter.service is enabled and started
  • Molecule tests passed

Upgrading Scylla Enterprise from 2021 to 2022

Here I've spotted a problem related to systemd units. After upgrading 2022.2, the unit file corresponding to node-exporter.service is removed. Let me show an example if systemctl status node-exporter.service is executed:

● node-exporter.service
    Loaded: not-found (Reason: Unit node-exporter.service not found.)
    Active: active (running) since Wed 2023-06-21 17:20:46 UTC; 1h 39min ago

So, if I run systemctl start node-exporter.service, it will fail.

The solution here seems to be calling a handler for reloading systemd configuration (there's an unused one there), but probably Molecule will fail (because Scylla images aren't using systemd). All handlers that manages systemd unit must be skipped from testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ansible-scylla-node: 'scylla-node-exporter' service is not enabled by default
1 participant