Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scylla-node: don't upgrade already installed scylla unless explicitly requested #288

Closed
wants to merge 1 commit into from
Closed

scylla-node: don't upgrade already installed scylla unless explicitly requested #288

wants to merge 1 commit into from

Conversation

vladzcloudius
Copy link
Collaborator

No description provided.

@vladzcloudius
Copy link
Collaborator Author

Guys, please, don't merge yet. I'll do it myself.

tarzanek
tarzanek reviewed Sep 22, 2023
View reviewed changes
ansible-scylla-node/tasks/Debian.yml
scylla_version_to_install: "{{ scylla_version }}"

- name: Install Scylla packages
include_tasks: Debian_install.yml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

introduce instead a check if versions match or not and stop before doing damage

tarzanek
tarzanek reviewed Sep 22, 2023
View reviewed changes
ansible-scylla-node/defaults/main.yml
scylla_is_installed: False

# Set to true if you want to allow a Role to upgrade and already installed Scylla
scylla_allow_upgrades: False
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to scylla force package install instead?

upgrade is elsewhere

@tarzanek
Copy link
Collaborator

tarzanek commented Sep 22, 2023 •
edited
Loading

offtopic: let's write the proper (private build) version to metadata/inventory to error out, too

@vladzcloudius
Copy link
Collaborator Author

vladzcloudius commented Sep 22, 2023 •
edited
Loading

We brainstormed with Lubos and it was decided to rewrite this PR completely.
The idea is to implement the following logic:

  1. The flow in question will never upgrade/downgrade the already installed scylla version.
  2. The Role by default will error out if the installed scylla version is different from the one specified in scylla_version.
  3. The Role will always install the scylla version specified in scylla_version on the node that doesn't have any scylla installed.
  4. There will be a flag that would allow disabling the check (2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarzanek tarzanek tarzanek left review comments

@igorribeiroduarte igorribeiroduarte igorribeiroduarte approved these changes

@ebenzecri ebenzecri Awaiting requested review from ebenzecri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladzcloudius @tarzanek @igorribeiroduarte