Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix - scylla-node] - Ansible builtin + when condition start node #372

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[Fix - scylla-node] - Ansible builtin + when condition start node #372

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1ec685d
common - update builtin + fix empty when condition
unkls Apr 3, 2024
860101e
ansible-scylla-node: support running the role on limited number of no…
unkls Apr 5, 2024
8cf774a
ansible-scylla-node: Update set_fact to use builtin modules from ansi…
unkls Apr 5, 2024
396fbc7
Merge branch 'fix-scylla-node-ansible-2.14' of github.com:unkls/scyll…
unkls Apr 5, 2024
6e7fefb
ansible-scylla-node: Remove the added line to adhere to the current c…
unkls Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ansible-scylla-node/tasks/common.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,17 +305,17 @@
# have an actual value resolved.
# One way to do that is to resolve it and store as an Ansible fact.
- name: Resolve a scylla_listen_address as a fact
set_fact:
ansible.builtin.set_fact:
listen_address: "{{ scylla_listen_address }}"

# The same relates to the below
- name: Resolve scylla_rpc_address
set_fact:
ansible.builtin.set_fact:
rpc_address: "{{ scylla_rpc_address }}"

# The same relates to the below
- name: Resolve scylla_broadcast_address
set_fact:
ansible.builtin.set_fact:
broadcast_address: "{{ scylla_broadcast_address }}"

- name: start_scylla_service dependent tasks
Expand All @@ -329,13 +329,14 @@
run_once: true
include_tasks: start_one_node.yml
loop: "{{ groups['scylla'] }}"
when: hostvars[item]['broadcast_address'] in scylla_seeds or item in scylla_seeds
when: (hostvars[item]['broadcast_address'] is defined) and ((hostvars[item]['broadcast_address'] in scylla_seeds) or (item in scylla_seeds))

- name: Start scylla non-seeds nodes serially
run_once: true
include_tasks: start_one_node.yml
loop: "{{ groups['scylla'] }}"
when:
- hostvars[item]['broadcast_address'] is defined
- item not in scylla_seeds
- hostvars[item]['broadcast_address'] not in scylla_seeds

Expand Down