ansible-scylla-node: Allow auto-detecting nvme cards #394
Conversation
| block: | ||
| - name: Get list of NVMEs | ||
| shell: | | ||
| nvme list | awk '{print $1}' | tail -n +3 |
There was a problem hiding this comment.
nvme is not installed by default. You need to install it before you can use it.
There was a problem hiding this comment.
On Ubuntu this is an nvme-cli package for example.
There was a problem hiding this comment.
Other than that - very nice idea.
There was a problem hiding this comment.
I'm now installing nvme-cli for both, Debian and RH.
| block: | ||
| - name: Get list of NVMEs | ||
| shell: | | ||
| nvme list | awk '{print $1}' | tail -n +3 |
There was a problem hiding this comment.
I tested on an AWS instance: it didn't have nvme-cli installed.
Perhaps lsblk is a safer option.
There was a problem hiding this comment.
lsblk would show non-nvme disks as well.
I've added nvme-cli to the list of dependencies in the role.
igorribeiroduarte
force-pushed
the
detect_nvmes
branch
from
4f02361 to
dab72b2
Compare
This patch adds a detect_nvmes field, which when set to True will use 'nvme list' command for getting the list of nvme devices in the machine and pass all of them to scylla_raid_setup.
igorribeiroduarte
force-pushed
the
detect_nvmes
branch
from
dab72b2 to
e2519f4
Compare
| @@ -190,6 +190,7 @@ scylla_dependencies: | |||
| - curl | |||
| - wget | |||
| - python3-yaml # this will fail on non centos systems | |||
There was a problem hiding this comment.
Unrelated to this PR: this comment is BS ;)
| @@ -120,6 +120,11 @@ | |||
| for i in `yum search python3|grep -i pyyaml|awk '{ print $1 }'`; do sudo yum -y install $i; done | |||
| become: true | |||
|
|
|||
| - name: install nvme-cli | |||
| shell: | | |||
| yum install -y nvme-cli | |||
There was a problem hiding this comment.
I wonder why we don't use scylla_dependencies for RH too?
This patch adds a
detect_nvmesfield, which when set to True will use 'nvme list' command for getting the list of nvme devices in the machine and pass all of them to scylla_raid_setup.