ansible-scylla-node: Add a way to set additional scylla command line … #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parameters (e.g. seastar ones) Before this patch we could have set additional scylla command line parameters in a hackish way via io_conf variable. This patch adds an explicit way to set SCYLLA_ARGS macro in /etc/default/scylla-server file. A new variable is added to achieve so: scylla_args_value. The non-empty value set to this variable is going to override/enforce the SCYLLA_ARGS. Tested manually with value set and not set. Signed-off-by: Vlad Zolotarov <[email protected]>
ebenzecri
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…parameters (e.g. seastar ones)
Before this patch we could have set additional scylla command line parameters in a hackish way via io_conf variable.
This patch adds an explicit way to set SCYLLA_ARGS macro in /etc/default/scylla-server file.
A new variable is added to achieve so: scylla_args_value. The non-empty value set to this variable is going to override/enforce the SCYLLA_ARGS.
Tested manually with value set and not set.