fix(pipelines): call docker login on all pipelines

we introdude this call ontop of the call we having in SCT code so we won't hit the limit while pulling hydra images themselves Fixes: scylladb/scylla-pkg#4634
scylladb · Dec 3, 2024 · 51f564e · 51f564e
1 parent 5389d67
commit 51f564e
Show file tree

Hide file tree

Showing 11 changed files with 25 additions and 0 deletions.
diff --git a/Jenkinsfile b/Jenkinsfile
@@ -92,6 +92,7 @@ pipeline {
             }
             steps {
                 script {
+                    dockerLogin(params)
                     try {
                         sh './docker/env/hydra.sh pre-commit'
                         // also check the commit-messge for the rules we want
@@ -172,6 +173,8 @@ pipeline {
                             dir('scylla-cluster-tests') {
                                 checkout scm
 
+                                dockerLogin(params)
+
                                 wrap([$class: 'BuildUser']) {
                                     echo "calling createSctRunner"
                                     timeout(time: 5, unit: 'MINUTES') {
@@ -225,6 +228,7 @@ pipeline {
                                         dir(working_dir) {
                                             checkout scm
                                         }
+                                        dockerLogin(params)
                                         if (sct_runner_backends.contains(backend)){
                                             try {
                                                 wrap([$class: 'BuildUser']) {

diff --git a/vars/artifactsPipeline.groovy b/vars/artifactsPipeline.groovy
@@ -136,6 +136,7 @@ def call(Map pipelineParams) {
                                                     checkout scm
                                                 }
                                             }
+                                            dockerLogin(params)
                                         }
                                         stage('Create Argus Test Run') {
                                             catchError(stageResult: 'FAILURE') {

diff --git a/vars/byoLongevityPipeline.groovy b/vars/byoLongevityPipeline.groovy
@@ -134,6 +134,7 @@ def call() {
 
                       checkoutQaInternal(params)
                   }
+                  dockerLogin(params)
                }
             }
             stage('Create SCT Runner') {

diff --git a/vars/dockerLogin.groovy b/vars/dockerLogin.groovy
@@ -0,0 +1,10 @@
+#!groovy
+
+def call(Map params = [:]) {
+    withCredentials([
+			string(credentialsId: 'docker-hub-jenkins-user', variable: 'DOCKER_USERNAME'),
+			string(credentialsId: 'docker-hub-api-key', variable: 'DOCKER_PASSWORD')
+		]) {
+	        sh 'docker login -u $DOCKER_USERNAME -p $DOCKER_PASSWORD'
+    }
+}
diff --git a/vars/jepsenPipeline.groovy b/vars/jepsenPipeline.groovy
@@ -114,6 +114,7 @@ def call(Map pipelineParams) {
                             checkoutQaInternal(params)
                         }
                     }
+                    dockerLogin(params)
                 }
             }
             stage('Create Argus Test Run') {

diff --git a/vars/longevityPipeline.groovy b/vars/longevityPipeline.groovy
@@ -215,6 +215,7 @@ def call(Map pipelineParams) {
                             checkoutQaInternal(params)
                         }
                     }
+                    dockerLogin(params)
                 }
             }
             stage('Create Argus Test Run') {

diff --git a/vars/managerPipeline.groovy b/vars/managerPipeline.groovy
@@ -197,6 +197,7 @@ def call(Map pipelineParams) {
                         checkout scm
                         checkoutQaInternal(params)
                     }
+                    dockerLogin(params)
                }
             }
             stage('Create Argus Test Run') {

diff --git a/vars/perfRegressionParallelPipeline.groovy b/vars/perfRegressionParallelPipeline.groovy
@@ -175,6 +175,7 @@ def call(Map pipelineParams) {
                                     loadEnvFromString(params.extra_environment_variables)
                                     dir('scylla-cluster-tests') {
                                         checkout scm
+                                        dockerLogin(params)
                                         (testDuration, testRunTimeout, runnerTimeout, collectLogsTimeout, resourceCleanupTimeout) = getJobTimeouts(params, builder.region)
                                         base_versions_list = params.base_versions.contains('.') ? params.base_versions.split('\\,') : []
                                         def new_repo = params.new_scylla_repo
@@ -265,6 +266,7 @@ def call(Map pipelineParams) {
                                                             dir('scylla-cluster-tests') {
                                                                 checkout scm
                                                             }
+                                                        dockerLogin(params)
                                                         }
                                                     }
                                                 }

diff --git a/vars/perfSearchBestConfigParallelPipeline.groovy b/vars/perfSearchBestConfigParallelPipeline.groovy
@@ -154,6 +154,7 @@ def call(Map pipelineParams) {
                                 wrap([$class: 'BuildUser']) {
                                     dir('scylla-cluster-tests') {
                                         checkout scm
+                                        dockerLogin(params)
                                         (testDuration, testRunTimeout, runnerTimeout, collectLogsTimeout, resourceCleanupTimeout) = getJobTimeouts(params, builder.region)
                                     }
                                 }

diff --git a/vars/rollingOperatorUpgradePipeline.groovy b/vars/rollingOperatorUpgradePipeline.groovy
@@ -119,6 +119,7 @@ def call(Map pipelineParams) {
                                 wrap([$class: 'BuildUser']) {
                                     dir('scylla-cluster-tests') {
                                         checkout scm
+                                        dockerLogin(params)
                                         (testDuration, testRunTimeout, runnerTimeout, collectLogsTimeout, resourceCleanupTimeout) = getJobTimeouts(params, builder.region)
                                     }
                                 }

diff --git a/vars/rollingUpgradePipeline.groovy b/vars/rollingUpgradePipeline.groovy
@@ -131,6 +131,7 @@ def call(Map pipelineParams) {
                                     dir('scylla-cluster-tests') {
                                         checkout scm
                                         checkoutQaInternal(params)
+                                        dockerLogin(params)
 
                                         ArrayList base_versions_list = params.base_versions.contains('.') ? params.base_versions.split('\\,') : []
                                         supportedVersions = supportedUpgradeFromVersions(
@@ -207,6 +208,7 @@ def call(Map pipelineParams) {
                                                                 checkoutQaInternal(params)
                                                             }
                                                         }
+                                                        dockerLogin(params)
                                                     }
                                                 }
                                             }
-Original file line number
+Diff line change
@@ Expand Up / @@ -134,6 +134,7 @@ def call() { @@
                           checkoutQaInternal(params)
                       }
+                      dockerLogin(params)
                    }
                 }
                 stage('Create SCT Runner') {
@@ Expand Down @@