Skip to content

Commit

Permalink
fix(test_workload_types): adjust workload comparison for 2024.2
Browse files Browse the repository at this point in the history
adjust change #8922
to work with 2024.2
and use ComparableScyllaVersion SCT utility as suggested
  • Loading branch information
temichus committed Oct 20, 2024
1 parent 99d539b commit 9018c7f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions sla_per_user_system_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
from sdcm.es import ES
from sdcm.sct_events import Severity
from sdcm.sct_events.workload_prioritisation import WorkloadPrioritisationEvent
from sdcm.utils.version_utils import ComparableScyllaVersion
from test_lib.sla import ServiceLevel, Role, User


Expand Down Expand Up @@ -828,8 +829,7 @@ def _compare_workloads_c_s_metrics(self, workloads_queue: list) -> dict:
comparison_axis = {"latency 95th percentile": 2.0,
"latency 99th percentile": 2.0,
"op rate": 2.0}
release = parse_version(self.db_cluster.nodes[0].scylla_version.replace("~", "-")).release
if release[0] > 2024 or (release[0] == 2024 and release[1] >= 3):
if ComparableScyllaVersion(self.db_cluster.nodes[0].scylla_version) >= '2024.2.0~rc3':
# Running the test with 2024.3 - deviation was improved
comparison_axis = {"latency 95th percentile": 1.0,
"latency 99th percentile": 1.0,
Expand Down

0 comments on commit 9018c7f

Please sign in to comment.