fix(nodetool rebuild): use repair instead of rebuild if no tablets support #9073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bhalevy , can you please advise, following scylladb/scylladb#20084 (comment) - IIUC, in case scylladb/scylladb#17852 is open all DC nodes should be manually repaired. and secondly, i'm not sure, is it right to backport this fix to 2024/6.x ? (it may have an extensive impact on longevities and testing for this PR) |
yarongilor
added
area/tablets
and removed
backport/2024.2
yarongilor
force-pushed
the
skip_rebuild_streaming_err_with_tablets
branch
from
56d1bbe to
5340448
Compare
…pport if no tables support for nodetool rebuild, test should use an alternative action of repair. it should then disable load-balancing and repair all nodes in this datacenter. refs: scylladb/scylladb#17575 refs: scylladb/scylladb#20084 (comment)
yarongilor
force-pushed
the
skip_rebuild_streaming_err_with_tablets
branch
from
5340448 to
f24debe
Compare
fruch
reviewed
Nov 10, 2024
| with self.cluster.cql_connection_patient(self.target_node) as session: | ||
| if is_tablets_feature_enabled(session=session) and not is_rebuild_supported: | ||
| for node in [n for n in self.cluster.nodes if n.dc_idx == self.target_node.dc_idx]: | ||
| node.run_nodetool(sub_cmd="repair") |
There was a problem hiding this comment.
I would recommend doing long_running=True, retry=0
also maybe to consider hard timeout
There was a problem hiding this comment.
also I'm not sure you have guarantee all the nodes in this DC are up and running...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if no tables support for nodetool rebuild, test should use an alternative action of repair. it should then disable load-balancing and repair all nodes in this datacenter.
refs: scylladb/scylladb#17575
refs: scylladb/scylladb#20084 (comment)
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)