Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(elacticity with nemesis): test 90 percent with supported nemesis #9796

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test(elacticity with nemesis): test 90 percent with supported nemesis #9796

wants to merge 1 commit into from

Conversation

yarongilor
Copy link
Contributor

@yarongilor yarongilor commented Jan 13, 2025 •
edited
Loading

test supported nemesis with 90 percent
Task: #9155

Testing

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

@yarongilor yarongilor changed the title test(elacticity with nemesis): test 90 percent with nemesis test(elacticity with nemesis): test 90 percent with supported nemesis Jan 13, 2025
@yarongilor yarongilor force-pushed the 90_percent_with_nemesis_pass branch 7 times, most recently from ad48efb to 4bb49dc Compare January 19, 2025 18:24
@yarongilor yarongilor added backport/none Backport is not required area/elastic cloud Issues related to the elastic cloud project labels Jan 20, 2025
@yarongilor
Copy link
Contributor Author

TODO: check if this PR also requires updating nemesis unit-test following the new added label.

@yarongilor
Copy link
Contributor Author

The test of 40 hours passed ok overall.
It had one nemesis failure with a new scylla issue.
It got 2 very small reactor stalls (that indicated a known issue).

test(elacticity with nemesis): test 90 percent with nemesis
0d8f733 
test supported nemesis with 90 percent
@yarongilor yarongilor force-pushed the 90_percent_with_nemesis_pass branch from 4bb49dc to 0d8f733 Compare January 22, 2025 16:54
@yarongilor yarongilor marked this pull request as ready for review January 22, 2025 16:54
yarongilor
yarongilor commented Jan 23, 2025
View reviewed changes
test-cases/features/elasticity-90-percent-with-nemesis.yaml
nemesis_grow_shrink_instance_type: 'i4i.large'

instance_type_loader: 'c6i.2xlarge'
instance_type_monitor: 't3.large'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about setting this instance_type_monitor, but no harm with it, and probably keeps consistent with similar other tests.

@scylladbbot
Copy link

@yarongilor new branch branch-2025.1 was added, please add backport label if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pehala pehala pehala approved these changes

@cezarmoise cezarmoise Awaiting requested review from cezarmoise

@Lakshmipathi Lakshmipathi Awaiting requested review from Lakshmipathi

At least 2 approving reviews are required to merge this pull request.

Assignees

@yarongilor yarongilor

Labels
area/elastic cloud Issues related to the elastic cloud project backport/none Backport is not required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yarongilor @scylladbbot @pehala