cqlsh.py: Send DESCRIBE statement to server before parsing #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to parse a DESCRIBE statement before performing it forces us to update cqlsh whenever a new element of the schema that could be described is introduced. We should try to rely on the server and only in the case of a failure (when the version of the server is old and it doesn't recognize the query) should we try to parse it and perform locally. Trying to parse it first may lead to rejecting DESCRIBE statements that would otherwise be valid -- if the grammar used by cqlsh hasn't caught up with Scylla yet.
The latter method is not declared, so use the former.
We add two small tests to verify that splitting DESCRIBE statements work correctly. We do it by hand now and we need to make sure nothing has broken.
|
Version 2:
|
sylwiaszunejko
approved these changes
Aug 30, 2024
fruch
approved these changes
Sep 2, 2024
|
Now we need A PR to pull this into Scylla core |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to parse a DESCRIBE statement before performing
it forces us to update cqlsh whenever a new element of
the schema that could be described is introduced. We should
try to rely on the server and only in the case of a failure
(when the version of the server is old and it doesn't
recognize the query) should we try to parse it and perform
locally.
Trying to parse it first may lead to rejecting DESCRIBE
statements that would otherwise be valid -- if the grammar
used by cqlsh hasn't caught up with Scylla yet.
Fixes #100