cython: fix the usage of cython #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the change to make cqlsh platfrom specific, we introduce an option to disable cython compilation phase. that option was broken and disable cython completly, which in turn broken the cibuildwheel process, since wheel didn't have any compiled parts any more. this change switch the disable option to be base on environment variable cause of a lack alternatives Ref: https://discuss.python.org/t/explicit-optional-cythonization-via-config-setting-post-pep517-and-install-option-deprecation/25379
tchaikov
approved these changes
Sep 10, 2024
It's bit too generic without some prefix, any it might not be needed. |
it's still needed, since dbuild doesn't have python-dev installed, we can't compile c extensions in it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the change to make cqlsh platfrom specific, we introduce an option to disable cython compilation phase.
that option was broken and disable cython completly, which in turn broken the cibuildwheel process, since wheel didn't have any compiled parts any more.
this change switch the disable option to be base on environment variable cause of a lack alternatives
Ref: https://discuss.python.org/t/explicit-optional-cythonization-via-config-setting-post-pep517-and-install-option-deprecation/25379