Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the tab-completion support of SERVICE_LEVEL statements #48

Merged
merged 2 commits into from
May 22, 2024

Conversation

fruch
Copy link
Collaborator

@fruch fruch commented Sep 7, 2023

Fixes: #43

TODOs

  • - add test for enterprise in github action
  • - add unit test for SLA

@fruch fruch requested review from Lorak-mmk and eliransin September 7, 2023 06:04
@fruch fruch force-pushed the support_tab_complication_sla branch 2 times, most recently from 702eabc to 69b76be Compare September 13, 2023 06:59
@fruch fruch requested a review from juliayakovlev September 13, 2023 07:01
@fruch
Copy link
Collaborator Author

fruch commented Sep 13, 2023

@eliransin want to take it for a test ride ?

@fruch fruch force-pushed the support_tab_complication_sla branch from 69b76be to d053906 Compare September 13, 2023 07:10
Copy link

@juliayakovlev juliayakovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are few options/statements that should be added

@fruch fruch force-pushed the support_tab_complication_sla branch 2 times, most recently from b6c9f68 to 8ea0818 Compare September 20, 2023 18:38
@fruch fruch requested a review from juliayakovlev September 21, 2023 09:33
@fruch fruch force-pushed the support_tab_complication_sla branch from 8ea0818 to d6be168 Compare September 21, 2023 09:34
pylib/cqlshlib/cql3handling.py Show resolved Hide resolved
pylib/cqlshlib/cql3handling.py Outdated Show resolved Hide resolved
@roydahan
Copy link
Collaborator

@fruch I guess you're still waiting a review here...

@Lorak-mmk could you please review?

Who is the main maintainer of this repository?

@Lorak-mmk
Copy link
Collaborator

@fruch I guess you're still waiting a review here...

@Lorak-mmk could you please review?

Who is the main maintainer of this repository?

I did review and I'm waiting for a response to my comment, I pinged two times.

@roydahan
Copy link
Collaborator

Thanks, weird that your review appears as dismissed, but no tracking of why.

@roydahan
Copy link
Collaborator

@fruch ?

@fruch fruch force-pushed the support_tab_complication_sla branch 2 times, most recently from 970eba2 to 88f2460 Compare May 22, 2024 17:33
fruch added 2 commits May 22, 2024 20:49
@fruch fruch force-pushed the support_tab_complication_sla branch from 88f2460 to 63184f1 Compare May 22, 2024 17:49
@fruch fruch dismissed Lorak-mmk’s stale review May 22, 2024 18:07

now the command mentioned are supported

@fruch fruch merged commit c3c586b into scylladb:master May 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cqlsh doesn't provide context sensitive help for service levels
4 participants