-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cqlsh.py: change shebang to /usr/bin/env python3 #98
Conversation
To run python executables on scylla-python3, we need to specify /usr/bin/env python3 on shebang, otherwise the script run on /usr/bin/python3. Fixes scylladb#97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
do we have confirmation it's fixes the issue ? |
@syuu1228 please confirm it is fixing the issue, if it is let;s get it in |
Here's the test result on local Rocky9 VM:
It says
It able to load cassndra module since it using scylla-python3.
Also, |
On which test we are seeing this failing ? |
@fruch can we merge it? |
We can even that I don't see it broken anywhere |
To run python executables on scylla-python3, we need to specify /usr/bin/env python3 on shebang, otherwise the script run on /usr/bin/python3.
Fixes #97