lib/scylla_cloud: use functool.cache to cache identify_cloud_async()

this change is a follow-up of d97e311, which caches the result
of `identify_cloud_async()` using a global variable. it would be
more idiomatic to use `functool.cache` for caching a costy function
like `identify_cloud_async()`, so in this change we use it for
caching. simpler this way. and more importantly, it is more readable.

Signed-off-by: Kefu Chai <[email protected]>

lib/scylla_cloud.py

@@ -4,6 +4,7 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
+import functools
 import json
 import logging
 import os
@@ -906,17 +907,15 @@ async def identify_cloud_async():
             break
     return result
 
-_identify_cloud_result = None
+
+@functools.cache
 def identify_cloud():
-    global _identify_cloud_result
-    if _identify_cloud_result:
-        return _identify_cloud_result
     time_start = datetime.datetime.now()
     result = asyncio.run(identify_cloud_async())
     time_end = datetime.datetime.now()
-    _identify_cloud_result = result
     return result
 
+
 def is_ec2():
     return identify_cloud() == aws_instance