(cloud images): add environment default tag
#566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaronkaikov
force-pushed
the
set-env
branch
2 times, most recently
from
95291e7 to
9b7d40d
Compare
fruch
reviewed
Dec 24, 2024
yaronkaikov
force-pushed
the
set-env
branch
3 times, most recently
from
d44593c to
271f9f1
Compare
Annamikhlin
reviewed
Dec 24, 2024
packer/build_image.sh
Outdated
| @@ -238,6 +245,7 @@ if [ "$BUILD_MODE" = "debug" ]; then | |||
| fi | |||
| if $DEBUG ; then | |||
| IMAGE_NAME="debug-$IMAGE_NAME" | |||
| ENV_TAG="debug" | |||
There was a problem hiding this comment.
Why to add it twice? in line 17 and here..
There was a problem hiding this comment.
leftover , removed
Annamikhlin
reviewed
Dec 24, 2024
Adding a logic for the `environment` tag for better image search default value is set for `debug` - master tag value will be `daily` - releases, the tag value will be `candidate` (and we modify it to `production` once we promote) - debug jobs (everything running under `machine-image` gating, `byo` or `releng-testing`) the value will be debug There is one special case for private builds that will be handled in a separate PR This is a prep for scylladb/scylla-pkg#4077
This was referenced Dec 25, 2024
This was referenced Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a logic for the
environmenttag for better image searchThe default value is set for
debugdailycandidate(and we modify it toproductiononce we promote)machine-imagegating,byoorreleng-testing) the value will be debugThere is one special case for private builds that will be handled in a separate PR
This is a prep for https://github.com/scylladb/scylla-pkg/issues/4077
Need to be merge only after https://github.com/scylladb/scylla-pkg/pull/4725