scylla_install_image: disable cloud provider agents #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently if BYOA customer will assigned required AWS Profile on instance or will deploy scylla in GCP customer will able to fetch metadata about the OS itself, and also will able to execute command on a target instance, which may leads to loose of control for instances deployed in BYOA. Fixes: scylladb/scylla-pkg#4883
d-helios
approved these changes
Feb 10, 2025
fruch
reviewed
Feb 10, 2025
| elif args.target_cloud == 'azure': | ||
| kernel_opt = ' rootdelay=300' | ||
| grub_variable = 'GRUB_CMDLINE_LINUX' | ||
| run('systemctl mask walinuxagent', shell=True, check=True) |
There was a problem hiding this comment.
Aren't we using this for something in SCT ?
There was a problem hiding this comment.
yes, we use it for rebooting with running OS command (reboot -f) due issue with SDK (scylladb/scylla-cluster-tests#6628)
We would need to adjust SCT to enable it back when VM is provisioned.
There was a problem hiding this comment.
@soyacz Can you open an issue or send a fix? we should probably also have it for 2025.1 since this is about to be backported
There was a problem hiding this comment.
Thanks @soyacz , I assume we can move forward with this PR then ?
soyacz
added a commit
to soyacz/scylla-cluster-tests
that referenced
this pull request
Feb 11, 2025
Linux agent on Scylla instances on Azure is disabled by default. scylladb/scylla-machine-image#627 Add cloud init script that enables it back for testing purposes.
3 tasks
soyacz
added a commit
to soyacz/scylla-cluster-tests
that referenced
this pull request
Feb 11, 2025
Linux agent on Scylla instances on Azure is disabled by default. scylladb/scylla-machine-image#627 Add cloud init script that enables it back for testing purposes.
soyacz
added a commit
to soyacz/scylla-cluster-tests
that referenced
this pull request
Feb 11, 2025
Linux agent on Scylla instances on Azure is disabled by default. scylladb/scylla-machine-image#627 Add cloud init script that enables it back for testing purposes.
lsfreitas
approved these changes
Feb 11, 2025
fruch
pushed a commit
to scylladb/scylla-cluster-tests
that referenced
this pull request
Feb 11, 2025
Linux agent on Scylla instances on Azure is disabled by default. scylladb/scylla-machine-image#627 Add cloud init script that enables it back for testing purposes.
scylladbbot
pushed a commit
to scylladbbot/scylla-cluster-tests
that referenced
this pull request
Feb 11, 2025
Linux agent on Scylla instances on Azure is disabled by default. scylladb/scylla-machine-image#627 Add cloud init script that enables it back for testing purposes. (cherry picked from commit 6f24ccb)
3 tasks
Annamikhlin
approved these changes
Feb 11, 2025
soyacz
added a commit
to scylladb/scylla-cluster-tests
that referenced
this pull request
Feb 11, 2025
Linux agent on Scylla instances on Azure is disabled by default. scylladb/scylla-machine-image#627 Add cloud init script that enables it back for testing purposes. (cherry picked from commit 6f24ccb)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, if the BYOA customer is assigned the required AWS Profile on the instance or will deploy scylla in GCP customer will able to fetch metadata about the OS itself, and also be able to execute a command on a target instance, which may lead to loose of control for instances deployed in BYOA.
Fixes: https://github.com/scylladb/scylla-pkg/issues/4883
Testing