Spark 3.1.1 copy missing data #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarzanek
reviewed
Aug 9, 2023
| @@ -139,10 +139,63 @@ object Validator { | |||
|
|
|||
| val failures = runValidation(migratorConfig) | |||
|
|
|||
| if (failures.isEmpty) log.info("No comparison failures found - enjoy your day!") | |||
| else { | |||
| if (failures.isEmpty) { | |||
There was a problem hiding this comment.
don't forget that
config.validation.failuresToFetch
will limit above failures
so figuring out proper https://github.com/scylladb/scylla-migrator/blob/master/config.yaml.example#L217 is the limit for this list
tarzanek
reviewed
Aug 9, 2023
| log.error("Found the following comparison failures:") | ||
| log.error(failures.mkString("\n")) | ||
|
|
||
| // Copy missing data here based on the discrepancies found | ||
| copyMissingData(migratorConfig, failures) |
There was a problem hiding this comment.
since this doesn't partition it will work only for small / tiny amount of rows
tarzanek
reviewed
Aug 9, 2023
added 2 commits
August 9, 2023 19:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick attempt at adding a method to copy missing rows
Links to #100