Embrace the AWS SDK v2 everywhere #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrf
force-pushed
the
aws-sdk2
branch
5 times, most recently
from
4532904 to
efeef76
Compare
- Use v2 clients both in the migrator and in the tests - Use Waiters instead of `Thread.sleep` - Add more AWS configuration properties as required by the S3 and DynamoDB clients
…ming artifact name Follow-up scylladb#155
scylladb#155 broke the support of streaming for DynamoDB. This commit fixes the regressions by: - making sure the data carried by RDDs is serializable when it needs to - getting back to the old manual loop to wait for the DynamoDB stream to be enabled because the `Waiter` was not working as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142
spark-kinesis-dynamodbstill uses V1, so we have to deal with that too)It might be possible to not use V1 at all, based on this, but would require additional work.
Waiterswhen possiblestreamChanges. This is now tested on AWS (our CI tests don’t cover that because of The sandboxed testing environment cannot use AWS #113).