-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove uses of SerializeValuesError
and deprecate it
#1149
Merged
wprzytula
merged 2 commits into
scylladb:main
from
wprzytula:remove-uses-of-serialize-values-error
Dec 11, 2024
Merged
Remove uses of SerializeValuesError
and deprecate it
#1149
wprzytula
merged 2 commits into
scylladb:main
from
wprzytula:remove-uses-of-serialize-values-error
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only one variant of the legacy SerializeValuesError was used: TooManyValues. In order to remove it entirely, a corresponding variant is introduced to the BuiltinSerializationErrorKind.
Lorak-mmk
requested changes
Dec 11, 2024
github-actions
bot
added
the
semver-checks-breaking
cargo-semver-checks reports that this PR introduces breaking API changes
label
Dec 11, 2024
See the following report for details: cargo semver-checks output
|
This is part of the legacy serialization framework.
wprzytula
force-pushed
the
remove-uses-of-serialize-values-error
branch
from
December 11, 2024 14:04
77d1846
to
59eb5c1
Compare
Lorak-mmk
approved these changes
Dec 11, 2024
wprzytula
added a commit
to wprzytula/scylla-rust-driver
that referenced
this pull request
Dec 11, 2024
…ize-values-error Remove uses of `SerializeValuesError` and deprecate it (cherry picked from commit 3d4dd69)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API-stability
Part of the effort to stabilize the API
semver-checks-breaking
cargo-semver-checks reports that this PR introduces breaking API changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SerializeValuesError
is part of the legacy serialization API, so it should be deprecated as well.Refs: #1139
Pre-review checklist
[ ] I have adjusted the documentation in./docs/source/
.[ ] I added appropriateFixes:
annotations to PR description.