Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: update UDT parsing example to be in line with docs #849

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

sylwiaszunejko
Copy link
Contributor

What's done

Previously there was some discrepancy between the examples, specifically how to parse a row into a custom type and and the docs about UDT.

Now it is updated.

Fixes: #829

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@sylwiaszunejko
Copy link
Contributor Author

CI fails due to: #847

@sylwiaszunejko sylwiaszunejko changed the title examples: update UDT parsing example to be inline with docs examples: update UDT parsing example to be in line with docs Oct 19, 2023
@piodul
Copy link
Collaborator

piodul commented Oct 19, 2023

#847 was fixed, please rebase.

@sylwiaszunejko
Copy link
Contributor Author

#847 was fixed, please rebase.

Done

@piodul piodul merged commit 2641d1b into scylladb:main Oct 19, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

examples: update UDT parsing examples
2 participants