Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: render supported enterprise versions from json #29

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

dgarcia360
Copy link
Collaborator

@dgarcia360 dgarcia360 commented Nov 19, 2024

Closes #27

Renders the enterprise table from the JSON file: docs/_static/data/enterprise_supported_versions.json

The JSON file will be available at https://docs.scylladb.com/stable/_static/data/enterprise_supported_versions.json once published.

How to test

  1. Clone this PR and build the docs.
  2. Open http://127.0.0.1:5500/versioning/version-support-enterprise/. The table should render as follows:

image

@dgarcia360 dgarcia360 marked this pull request as ready for review November 19, 2024 19:21
@annastuchlik annastuchlik self-requested a review November 21, 2024 10:56
@annastuchlik
Copy link
Collaborator

@dgarcia360 This all looks good. I just want to make sure I understand how to add future updates. When there's a new version, I need to:

  1. Add it to the JSON file docs/_static/data/enterprise_supported_versions.json.
  2. Provide all the details and set show_version_policy_link to true or false.

In this way, we will see the update both in the JSON file and on the/versioning/version-support-enterprise/page.

Please confirm before I merge it.

@annastuchlik
Copy link
Collaborator

@tzach Please have a look. I'm OK with that solution - it's the simplest one, and we have full control over the content.

@dgarcia360
Copy link
Collaborator Author

@annastuchlik Exactly

@tzach
Copy link
Collaborator

tzach commented Nov 24, 2024

LGTM

@annastuchlik annastuchlik merged commit 4899e33 into main Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a JSON version of ScyllaDB Enterprise Version Support
3 participants