align supported releases #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) fix not working link to ScyllaDB Web Install 2) removing script description since we already have README.md
|
Verification:
|
yaronkaikov
reviewed
Feb 15, 2024
Just checking it.. |
It's failing from |
That's weird. not related to any of the changes? in any case, we need to get it fixed :-) |
benipeled
reviewed
Feb 18, 2024
benipeled
reviewed
Feb 18, 2024
benipeled
reviewed
Feb 18, 2024
benipeled
approved these changes
Feb 18, 2024
to align supported versions this commit includes the following changes: 1) add check of supported Scylla versions in check_scylla_version() function. in case the specified version reached EOL, the script will will exit with relevant message 2) remove not supported versions from the script 3) remove version check in architecture check process 4) remove set_gpg_key() function - due to old GPG_KEY for not supported versions 5) updated help and README example versions Closes: scylladb#62
since 2024.1.0 - first GA already released. adding it to test.yml to run ci tests also on this version
when trying to install version 5.4.0 and above the following error is displayed: `E: Unable to correct problems, you have held broken packages.` adding installation of `-cqlsh` package to fix this error
Annamikhlin
force-pushed
the
supported_releases
branch
from
261bd3e to
eee3a00
Compare
when trying to install version 5.2.1, it installed the latest version of 5.2.1x (5.2.15) due to `head -n1` fixing it by adding -w option (match only whole word)
Annamikhlin
force-pushed
the
supported_releases
branch
from
eee3a00 to
f9ebc82
Compare
benipeled
approved these changes
Feb 19, 2024
|
@benipeled @yaronkaikov - I added 3 additional commits:
Verification for last commit f9ebc82 before the fix: after the fix with -w All CI tests passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following:
458ea03 - includes:
c01290b - to align supported versions this commit includes the following changes:
check_scylla_version()functionin case the specified version reached EOL, the script will exit with relevant message
set_gpg_key()function - due to old GPG_KEY for not supported versions35ae047 - adding 2024.1.0 to web-install ci tests as this version already released
9cb84a1 - fix error
E: Unable to correct problems, you have held broken packages- when trying to install 5.4.0 and abovef9ebc82 - when trying to install version 5.2.1, it is installing the latest version of 5.2.1x (5.2.15)
Closes: #62