Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Mining Submission #51

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Text Mining Submission #51

wants to merge 7 commits into from

Conversation

aehoppe
Copy link

@aehoppe aehoppe commented Feb 25, 2016

Submitting Text Mining project

Review on Reviewable

@frantonlin
Copy link

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 7 unresolved discussions.


message_scrape.py, line 7 [r1] (raw file):
Really good comments throughout. Remember to include your name in this main header comment though!


message_scrape.py, line 15 [r1] (raw file):
You didn't use threadname.


message_scrape.py, line 23 [r1] (raw file):
Ideally this wouldn't be hard coded in and somehow you you could input for the message tree. I know you said you attempted to using BeautifulSoup, but maybe even just putting in a number and then returning the name of the chat along with the results would be useful.


message_scrape.py, line 52 [r1] (raw file):
You don't actually need to keep track of total_words, you can just get the length of text.split().


message_scrape.py, line 63 [r1] (raw file):
Good job putting the most frequent at the top.


message_scrape.py, line 91 [r1] (raw file):
Looks good.


Text_Mining_Reflection_AHOPPE.pdf, line 0 [r1] (raw file):
Clearly conveys what you accomplished and why you made certain decisions.


Comments from the review on Reviewable.io

@rdiverdi
Copy link

rdiverdi commented May 5, 2016

Review status: 2 of 4 files reviewed at latest revision, 9 unresolved discussions.


markov_chat.py, line 1 [r2] (raw file):
Cool extension. I bet it gave you some funny outputs. The additions look good.


message_scrape.py, line 1 [r2] (raw file):
You didn't make any of the changes we suggested :(


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants