EFunkhouser MP3 code and report

[efunkhouser]

Not entirely certain the report will go through right as I pushed it from outside my virtual machine, but...fingers crossed?

[srli]

Review status: 0 of 5 files reviewed at latest revision, 10 unresolved discussions.

---

a discussion (no related file):
A readme briefly listing the steps required to run the project would be super helpful in a situation where your code is spread over multiple files. I've made a couple of comments on possible improvements, please take a look!

All in all, nicely done! The rolling average thing was pretty cool, and reading your writeup was really fun.

---

get_booktext.py, line 14 [r1] (raw file):
if exists(file_name):

Will also work

---

get_booktext.py, line 23 [r1] (raw file):
If both parts of the if statement return None, you can just stick it outside the conditional :P

---

one_book_sentiment.py, line 76 [r1] (raw file):
book_file_name.split(".")[0] is a safer way to do this. (Just in case you get something weird like "Clotelle.txts")

---

plot_all_books.py, line 5 [r1] (raw file):
Ah, for final turn ins, try to make sure your code can run without any modifications. When I tried to run this, it gave me errors until I uncommented all of these lines.

---

plot_all_books.py, line 48 [r1] (raw file):
I can't run this because I don't have plotly credentials, but since your report shows really pretty graphs I'll assume that this code works.

---

trim_booktext.py, line 1 [r1] (raw file):
Little nitpicky thing, you import pickle but never use it. Try to keep imports clean.

---

trim_booktext.py, line 19 [r1] (raw file):
Hmm, it's good that you're doing error checking here. But returning none will cause your code to error out later.

---

trim_booktext.py, line 48 [r1] (raw file):
If you pass in None to remove_junk_end, None.lower() will break. You can solve this by adding an if statement that will skip the rest of the function if None is returned from remove_junk_beginning()

---

trim_booktext.py, line 52 [r1] (raw file):
You also can't write None to a file using f.write()

---

Comments from the review on Reviewable.io

[srli]

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 10 unresolved discussions.

---

Comments from the review on Reviewable.io