Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Support tssln #172

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Add: Support tssln #172

merged 4 commits into from
Jun 24, 2024

Conversation

sevenc-nanashi
Copy link
Contributor

@sevenc-nanashi sevenc-nanashi commented Jun 23, 2024

This PR adds importing/exporting ability for tssln (VoiSona) file.

Closes: #149

  • Import: Basic
  • Import: Pitch
  • Export: Basic
  • Export: Pitch

The pitch was too difficult for me, so I don't include in this pR.

@sevenc-nanashi sevenc-nanashi marked this pull request as draft June 23, 2024 01:54
@@ -1,3 +1,4 @@
kotlin.code.style=official
kotlin.js.compiler=ir
kotlin.daemon.jvmargs=-Xmx4G
kotlin.js.yarn=false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to quit yarn to use jsr packages (Kotlin/JS does not recognize .npmrc with yarn)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay let's just use npm. I'm always uncomfortable with the yarn.lock file as well 😂
Can we remove those yarn-specific files?

Copy link
Contributor Author

@sevenc-nanashi sevenc-nanashi Jun 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted yarn.lock but it spawns again somehow...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow it started to work, so I'm reverting this change.

@sevenc-nanashi sevenc-nanashi marked this pull request as ready for review June 23, 2024 12:37
@sdercolin sdercolin merged commit 2f895bf into sdercolin:develop Jun 24, 2024
1 check passed
sdercolin added a commit that referenced this pull request Jul 6, 2024
* Bump up version

* Create core module

* Move files

* Add some JsExport

* Add: Support analysis for lyrics with suffix

* Add functions for TS library (#164)

* Change: Use Array for better typing

* Add: Add generate functions

* Add: Add ability to build minimum core

* Add: Add wrapper

* Add: Add test

* Improve: gradlew test will run deno test

* Add: Add missing keys

* Change: Create documentToUfData / ufDataToDocument

* Fix: Fix name shadowing

* Add: Add 10 tracks test

* Change: Create project data

* Add: add parseFile and toFile

* Add: Add fromAny

* Add: Add convertJapaneseLyrics

* Add: Add ust

* Delete: Delete deno things

* Delete: Delete unused gitignore#

* Change: DocumentContainer -> ProjectContainer

* Change: Use KDoc

* Change: Use internal to hide error

* Change: Rename convertJapaneseLyrics

* Change: Change visibility

* Revert: webpack.config.d was required

* Fix resources resolve

* Use midi-file instead of midi-parser-js (#165)

* Change: Use midi-file

* Fix: Fix importing assets

* Fix: Run kotlinUpgradeYarnLock

* Fix: Fix resolver

* Change: Make ESModule conditional

* Delete: Delete workaround

* Delete: Delete unused dependency

* Revert: Re-add workaround

* Revert: Revert unrelated changes

* Update: Update yarn.lock

* Change: Re-throw error

* Fix: Fix error

* Fix: It throws string, not an Error

* Fix tasks about resources copy

---------

Co-authored-by: colin.weng <[email protected]>

* Export exceptions to JS (#167)

* Update Russian translation (#168)

* Change: Don't remove "っ" by default (#169)

* Change: Don't remove "っ" by default

* Delete: Why is there a new line?

* Allow specifying default lyrics via ImportParams (#170)

* Add: Allow specifying default lyrics via ImportParams

* Code: gradlew ktlintFormat

* Update: Update Format.kt

* Allow specifying ImportParams from JS, and export pitches (#171)

* Add: Support tssln (#172)

* Add: Support importing tssln

* Add: Add basic export

* Code: gradlew ktlintFormat

* Change: Use yarn

* Update: Update texts for tssln (#174)

* Update: Update texts

* Update: kotlinUpgradeYarnLock

* Fix: Fix around esm import

* Code: Format

* Export tssln to JS (#175)

* Add: Export tssln

* Change: Use val

* Fix some issues (#176)

* Fix: Fix some minor issues

* Add: Add comment

* Fix: Fix loading tssln from VST (#177)

* Fix: Fix loading tssln from VST

* Code: gradlew ktlintFormat

---------

Co-authored-by: sevenc-nanashi <[email protected]>
Co-authored-by: colin.weng <[email protected]>
Co-authored-by: Dmitry Kiryanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants