Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

add param to paginate #320

Open
wants to merge 3 commits into
base: 0.9
Choose a base branch
from
Open

Conversation

elha14
Copy link

@elha14 elha14 commented Aug 19, 2019

In case when we need to paginate we will do count query, when i need to select all column the count will use all column to, in my experience its not effective because in count we can just use 1 column
So i add column_count param in paginate, the param use to select which column that will be used in count query

orator/orm/builder.py Outdated Show resolved Hide resolved
orator/query/builder.py Outdated Show resolved Hide resolved
@mandarvaze
Copy link

Can you add tests ?

@elha14
Copy link
Author

elha14 commented Nov 25, 2019

Can you add tests ?

i already move my new param to last param in next commit
for test, i will do it later

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants