remove droping Error column

sdv-dev · Oct 31, 2023 · b0cc020 · b0cc020
1 parent 193ed6d
commit b0cc020
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 7 deletions.
diff --git a/sdmetrics/reports/multi_table/_properties/__init__.py b/sdmetrics/reports/multi_table/_properties/__init__.py
@@ -7,9 +7,9 @@
 from sdmetrics.reports.multi_table._properties.column_shapes import ColumnShapes
 from sdmetrics.reports.multi_table._properties.coverage import Coverage
 from sdmetrics.reports.multi_table._properties.inter_table_trends import InterTableTrends
+from sdmetrics.reports.multi_table._properties.relationship_validity import RelationshipValidity
 from sdmetrics.reports.multi_table._properties.structure import Structure
 from sdmetrics.reports.multi_table._properties.synthesis import Synthesis
-from sdmetrics.reports.multi_table._properties.relationship_validity import RelationshipValidity
 
 __all__ = [
     'BaseMultiTableProperty',

diff --git a/sdmetrics/reports/multi_table/_properties/cardinality.py b/sdmetrics/reports/multi_table/_properties/cardinality.py
@@ -67,9 +67,6 @@ def _generate_details(self, real_data, synthetic_data, metadata, progress_bar=No
             'Error': error_messages,
         })
 
-        if self.details['Error'].isna().all():
-            self.details = self.details.drop('Error', axis=1)
-
     def _get_table_relationships_plot(self, table_name):
         """Get the table relationships plot from the parent child relationship scores for a table.
 

diff --git a/sdmetrics/reports/multi_table/_properties/relationship_validity.py b/sdmetrics/reports/multi_table/_properties/relationship_validity.py
@@ -75,9 +75,6 @@ def _generate_details(self, real_data, synthetic_data, metadata, progress_bar=No
             'Error': error_messages,
         })
 
-        if self.details['Error'].isna().all():
-            self.details = self.details.drop('Error', axis=1)
-
     def _get_table_relationships_plot(self, table_name):
         """Get the table relationships plot from the parent child relationship scores for a table.