Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NewRowSynthesis on datetime columns without formats #473

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Fix NewRowSynthesis on datetime columns without formats #473

merged 2 commits into from
Oct 31, 2023

Conversation

fealho
Copy link
Member

@fealho fealho commented Oct 18, 2023 •
edited
Loading

CU-860qhu3zr

Partially resolve sdv-dev/SDGym#216 and resolve #337.

This PR adds support for datetime values as strings in NewRowSynthesis .

@fealho fealho marked this pull request as ready for review October 27, 2023 16:13
@fealho fealho requested a review from a team as a code owner October 27, 2023 16:13
@fealho fealho requested review from frances-h and removed request for a team October 27, 2023 16:13
@fealho fealho changed the title Fix datetime issue Fix NewRowSynthesis on datetime columns without formats Oct 27, 2023
frances-h
frances-h reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@frances-h frances-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add a test?

@fealho fealho merged commit f960c4a into main Oct 31, 2023
45 checks passed
@fealho fealho deleted the sdgym branch October 31, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frances-h frances-h frances-h approved these changes

@amontanez24 amontanez24 amontanez24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@fealho @amontanez24 @frances-h